Re: [PATCH 4/7] grep: read submodule entry with explicit repo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > -		object = parse_object_or_die(oid, NULL);
> > +		object_type = oid_object_info(&subrepo, oid, NULL);
> 
> One thing I wonder is whether we are missing out on some error
> conditions we used to get with parse_object_or_die() by using
> oid_object_info() instead. Do we need to be more defensive in
> investigating 'oid' before calling that helper, now?

For the purposes of grep, I don't think that this matters - we just want
to find the ultimate tree that this object represents.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux