> Just a quick note: grep_source_init_buf() is only called from > grep.c:1833, before its definition at grep.c:1869, so it could be marked > as static (as things stand). Do you anticipate any future callers from > outside of grep.c? (after removing the declaration from grep.h, you > would need to add a forward declaration or, better, move the definition > to before the call (or the call (and grep_buffer()) after the definition)). No, I do not - thanks for the note, and I'll make it static in the next reroll.
