Re: [PATCH] ci: use upload-artifacts v1 for dockerized jobs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 12, 2021 at 12:59 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Carlo Marcelo Arenas Belón  <carenas@xxxxxxxxx> writes:
>
> > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> > index 47876a4f02..9dd41a1742 100644
> > --- a/.github/workflows/main.yml
> > +++ b/.github/workflows/main.yml
> > @@ -258,7 +258,7 @@ jobs:
> >          - jobname: linux-musl
> >            image: alpine
> >          - jobname: Linux32
> > -          image: daald/ubuntu32:xenial
> > +          image: i386/ubuntu:xenial
>
> Intended or accidental?

yes!.

It was intended but more as an RFC, because I couldn't find an
explanation on what was the advantage of using this 5 year old
unofficial image when there was an equivalent official one that had
been updated just last month.

It was accidental, because I didn't realize I hadn't updated the log
message and it isn't needed to fix the regression which was the main
focus anyway.

>  At least it is not explained where this
> change comes from in the proposed log message.

The advantages of using an official image will be :

* more likely to be cached and therefore less likely to fail the job
* easier to move to a newer version (specially considering 16.04 is EOL)

Would it be better to drop or document it for v2?

Carlo




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux