Amidst all the talk of clang4 in another thread, I noticed that Debian unstable recently shipped a clang-14 package. So I tried it out, and it does find one small cleanup. And then looking at the surrounding code helped me find 2 more. :) [1/3]: range-diff: drop useless "offset" variable from read_patches() [2/3]: range-diff: handle unterminated lines in read_patches() [3/3]: range-diff: use ssize_t for parsed "len" in read_patches() range-diff.c | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) -Peff