On Wed, Aug 04, 2021 at 10:22:41AM -0400, Derrick Stolee wrote: > > * lh/systemd-timers (2021-07-02) 3 commits > > - maintenance: add support for systemd timers on Linux > > - maintenance: `git maintenance run` learned `--scheduler=<scheduler>` > > - cache.h: Introduce a generic "xdg_config_home_for(…)" function > > > > "git maintenance" scheduler learned to use systemd timers as a > > possible backend. > > > > Waiting for reviews. > > I just took another look at this series and see that there were a few > items that have yet to be addressed. CC'ing Lénaïc and reviewers to > see if those items will come in a v8. Here is a quick summary of my > understanding: > > * There are some non-ASCII characters in a code comment that are a > bit non-standard and could be replaced with ASCII representations. > (nit, but if re-rolling already this might be worth doing.) > > * There is some discussion about using string_list_split() instead > of hand-rolling a string splitter. Discussion decided that we > should _not_ use strbuf_split_buf(). It would be nice to later > create a version of strvec_split() that takes an arbitrary > delimiter, but isn't necessary for this series. I think this strvec part was the only thing I had commented on previously. I agree with your summary here (especially that we can punt on refactoring strvec_split() for this series). -Peff
