On Mon, Aug 02 2021, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > [...] >> @@ -3111,6 +3113,7 @@ static int files_reflog_expire(struct ref_store *ref_store, >> } >> } >> >> + assert(!unused_oid); >> (*prepare_fn)(refname, oid, cb.policy_cb); >> refs_for_each_reflog_ent(ref_store, refname, expire_reflog_ent, &cb); >> (*cleanup_fn)(cb.policy_cb); > > The preference in this codebase is > > ptr_to_function(params); > > over > > (*ptr_to_function)(params); > > Once it is written and committed, it is not worth changing, but just > for the record... Indeed, in this series I don't touch that (except items on the argument list), so refactoring that just for changing the syntax here didn't seem worth it.
