Tested in Windows (with 8.6) as well not to introduce any regressions +CC Tobias (gmail instead of the one bouncing in the SoB) On Tue, Aug 3, 2021 at 6:09 PM Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx> wrote: > > The following patches improve the user experience for gitk in macOS > by avoiding to abort if the terminal where it is running hasn't been > authorized for Automation as reported a few[1,2] times already. > > It has been tested in macOS 11.5.1 using both the system tk (8.5) and > the latest (8.6.11) from brew, the third[3] patch is needed for using > 8.6 and has been included with the gitk version from brew as well. > > Carlo Marcelo Arenas Belón (2): > gitk: skip calling osascript to set frontmost for tk >= 8.6 > gitk: avoid fatal error if `exec osascript` fails > > Tobias Pietzsch (1): > gitk: check main window visibility before waiting for it to show > > gitk | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > [1] https://lore.kernel.org/git/20180724065120.7664-1-sunshine@xxxxxxxxxxxxxx/ > [2] https://lore.kernel.org/git/20201025175149.11853-1-dev+git@xxxxxxxxx/ > [3] https://lore.kernel.org/git/pull.944.git.git.1610234771966.gitgitgadget@xxxxxxxxx/ > -- > 2.33.0.rc0.433.g9a510e7e11
