On 7/31/2021 1:27 PM, Elijah Newren via GitGitGadget wrote: > This series textually depends on en/ort-perf-batch-14, but the ideas are > orthogonal to it and orthogonal to previous series. It can be reviewed > independently. > > Changes since v1, addressing Eric's feedback: > > * Fixed a comment that became out-of-date in patch 1 > * Swapped commits 2 and 3 so that one can better motivate the other. > > Changes since v2, addressing Peff's feedback: > > * Rebased on en/ort-perf-batch-14 (resolving a trivial conflict with the > new string_list_init_nodup() usage) > * Added a new preliminary patch renaming str*_func() to str*_clear_func() > * Added a new final patch that hardcodes that we'll just use memory pools > > Changes since v3, as per Peff's feedback: > > * Don't only remove the extra complexity from the USE_MEMORY_POOL #define; > also remove the original bookkeeping complexity needed to track > individual frees when not using a memory pool. I read the discussion leading to these changes and gave this version another pass. Looks good to me. Thanks! -Stolee
