Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > Remove the conditional use of CURLAUTH_DIGEST_IE and > CURLOPT_USE_SSL. These two have been split from earlier simpler checks > against LIBCURL_VERSION_NUM for ease of review. > > The CURLAUTH_DIGEST_IE flag was added in 7.19.3[1], and > CURLOPT_USE_SSL in 7.16.4[2] or 7.17.0[3], depending on the source. As > noted in [2] it was then renamed around that time from the older > CURLOPT_FTP_SSL. > > 1. https://curl.se/libcurl/c/CURLOPT_HTTPAUTH.html > 2. https://curl.se/libcurl/c/CURLOPT_USE_SSL.html > 3. https://github.com/curl/curl/blob/master/docs/libcurl/symbols-in-versions I still think "depending on the source" is wronge. Let's read #2 (whose copy we also have in our comment) again: This option was known as CURLOPT_FTP_SSL up to 7.16.4, and the constants were known as CURLFTPSSL_* A program that uses the CURLOPT_USE_SSL symbol would have failed to compile with 7.16.4, as that version and older ones, even they had the feature itself, did not use CUROPT_USE_SSL to invoke the feature. That is how I read the above sentence. Perhaps everything after the first paragraph can be like this instead? The CURLAUTH_DIGEST_IE flag was added in 7.19.3 and CURLOPT_USE_SSL in 7.17.0. (cf. https://github.com/curl/curl/blob/master/docs/libcurl/symbols-in-versions) The patch text looks good to me. Thanks.
