On 7/28/2021 11:58 PM, Elijah Newren via GitGitGadget wrote: > This series textually depends on en/ort-perf-batch-14, but the ideas are > orthogonal to it and orthogonal to previous series. It can be reviewed > independently. > > This series is more about strmaps & memory pools than merge logic. CC'ing > Peff since he reviewed the strmap work[1], and that work included a number > of decisions that specifically had this series in mind. > > Changes since v1, addressing Eric's feedback: > > * Fixed a comment that became out-of-date in patch 1 > * Swapped commits 2 and 3 so that one can better motivate the other. Changes look good to me. Thanks! > Note: Stolee also had an interesting question about whether we should tweak > the mem_pool_*() API; he and I were both worried it was a bit much, so I've > left it out unless others on list chime in with their opinions on that > change. This was mostly a thought experiment on my part. There is no need to decide one way or another in this series since it would be easy to adapt what you have here to match a change to the mem_pool_*() API if we thought that was a good idea. (Still not sure it is.) Thanks, -Stolee
