Here is a new patchset (with no wrong patchs and numbering this time) with Junio's remarks integrated (the va_copy stuff, better documentation and patch comments and so on). strbuf_read remains a "I can read all the content of the file or the caller is supposed to die()" operation for now, as it's how it's used right now, this can be changed easily in the future if needs for it exists. I've also stripped as many STRBUF_INIT uses as possible, some people didn't liked it. I've kept its use for "static" strbufs where it's way more convenient that a function call. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html