On 7/23/2021 1:45 PM, Elijah Newren wrote: > On Wed, Jul 21, 2021 at 2:07 PM Derrick Stolee via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: >> ... >> diff --git a/t/t1092-sparse-checkout-compatibility.sh b/t/t1092-sparse-checkout-compatibility.sh >> index a3c01d588d8..a11d9d7f35d 100755 >> --- a/t/t1092-sparse-checkout-compatibility.sh >> +++ b/t/t1092-sparse-checkout-compatibility.sh >> @@ -340,13 +340,6 @@ test_expect_success 'status/add: outside sparse cone' ' >> >> test_sparse_match git status --porcelain=v2 && >> >> - # This "git add folder1/a" fails with a warning >> - # in the sparse repos, differing from the full >> - # repo. This is intentional. >> - test_sparse_match test_must_fail git add folder1/a && >> - test_sparse_match test_must_fail git add --refresh folder1/a && >> - test_all_match git status --porcelain=v2 && >> - > > Why was this chunk removed? Nothing in the commit message mentions > this, and it's not clear to me the reason for it. > > I tried adding it back in at the end of the series and it still works > (and further I can't change test_sparse_match to test_all_match and > have the test work). I mentioned this in a reply to Junio, but this hunk removal is confusing. As of this patch, this hunk causes a failure due to an error message not matching, specifically this error: + diff -u sparse-checkout-err sparse-index-err --- sparse-checkout-err 2021-07-26 13:30:50.304291264 +0000 +++ sparse-index-err 2021-07-26 13:30:50.308291259 +0000 @@ -1,5 +1 @@ -The following pathspecs didn't match any eligible path, but they do match index -entries outside the current sparse checkout: -folder1/a -hint: Disable or modify the sparsity rules if you intend to update such entries. -hint: Disable this message with "git config advice.updateSparsePath false" +fatal: pathspec 'folder1/a' did not match any files A similar test is added as a failure case in patch 4, then marked as success in patch 5. This organization of test changes could be organized better, so I will work on that in v2, along with your other suggestions. Thanks, -Stolee
