On Fri, Jul 23, 2021 at 8:55 AM Elijah Newren via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > Exact rename detection, via insert_file_table(), uses a hashmap to store > files by oid. Use a mem_pool for the hashmap entries so these can all be > allocated and deallocated together. > [...] > Signed-off-by: Elijah Newren <newren@xxxxxxxxx> > --- > diff --git a/diffcore-rename.c b/diffcore-rename.c > @@ -355,7 +357,7 @@ static int find_exact_renames(struct diff_options *options) > /* Free the hash data structure and entries */ > - hashmap_clear_and_free(&file_table, struct file_similarity, entry); > + hashmap_clear(&file_table); Does the in-code comment become a bit out of date with this change? (It might make sense to drop the comment altogether -- or, if not, explain that the hashmap entries get thrown away later with the pool?) Not necessarily worth a re-roll.
