Junio C Hamano <gitster@xxxxxxxxx> wrote: > Mike Hommey <mh@xxxxxxxxxxxx> writes: > > > The same things obviously apply to git-cvsimport and other scripts > > calling git-hash-object a lot. > > I *obviously* hate this patch, as it makes this Porcelain > command to be aware of the internal representation too much. Me too. I think its bad enough that fast-import knows the internal representation of a packfile. And its plumbing! > I wonder if letting fast-import handle the object creation is an > option, though. I agree. This is *exactly* what fast-import was built for. It really would be the better tool to use here. Much better than reinventing the wheel. Its already been invented twice for you in Git (normal object creation path and fast-import path). No need to do it a third time. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
