On Wed, Jul 21, 2021 at 06:37:41AM -0400, Jeff King wrote: > > @@ -242,9 +249,7 @@ static int load_bitmap_entries_v1(struct bitmap_index *index) > > xor_offset = read_u8(index->map, &index->map_pos); > > flags = read_u8(index->map, &index->map_pos); > > > > - if (nth_packed_object_id(&oid, index->pack, commit_idx_pos) < 0) > > - return error("corrupt ewah bitmap: commit index %u out of range", > > - (unsigned)commit_idx_pos); > > + nth_bitmap_object_oid(index, &oid, commit_idx_pos); > > What happened to our error check here? > > Should nth_bitmap_object_oid() be returning the value from > nth_packed_object_id()? Ah, sorry, I just saw your followup message. I'll look for the fix in the re-roll. -Peff