On Mon, Jun 21, 2021 at 06:25:04PM -0400, Taylor Blau wrote: > When writing a new bitmap, the bitmap writer code attempts to read the > existing bitmap (if one is present). This is done in order to quickly > permute the bits of any bitmaps for commits which appear in the existing > bitmap, and were also selected for the new bitmap. > > But since this code was added in 341fa34887 (pack-bitmap-write: use > existing bitmaps, 2020-12-08), the resources associated with opening an > existing bitmap were never released. > > It's fine to ignore this, but it's bad hygiene. It will also cause a > problem for the multi-pack-index builtin, which will be responsible not > only for writing bitmaps, but also for expiring any old multi-pack > bitmaps. > > If an existing bitmap was reused here, it will also be expired. That > will cause a problem on platforms which require file resources to be > closed before unlinking them, like Windows. Avoid this by ensuring we > close reused bitmaps with free_bitmap_index() before removing them. I agree with all of that. But just "it's a memory leak" would have contented me, too. :) -Peff
