Hi, I finally sat down and finished the last details in my git-commit.sh port and made it pass the test suite. The test suite is cruel, but awesome. There's one test that doesn't look right to me: t1400-update-ref.sh. The 'creating initial files' case does a git commit --amend and apparently expect to commit the changed contents of the file F, even though it hasn't been added to the index. Similarly, there's a git commit -F M just below it that does the same thing. I'm not sure how they pass with the shell script commit... Also, there is some overlap in the patch set with Pierre's nice strbuf work, but it's mostly just naming, and should be easy to work out. I have a couple of places where I manually add a NUL terminator, but I like Pierres approach of always implicitly doing that. I didn't work on this for a couple of weeks, and keeping up-to-date with the various git-commit.sh changes that happened in the meantime (templates, different option semantics etc) wasn't fun. Also I don't really have the time to maintain this out of tree, these days, so I'd really appreciate, now that the work is finished, if we can get it in. cheers, Kristian - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
