On Fri, Jul 16, 2021 at 04:13:06PM +0200, Ævar Arnfjörð Bjarmason wrote: > In the preceding commit the last caller that passed a non-NULL OID was > changed to pass NULL to lock_ref_oid_basic(). As noted in preceding > commits use of this API has been going away (we should use ref > transactions, or lock_raw_rew()), so we're unlikely to gain new > callers that want to pass the "oid". s/rew/ref/ > So let's remove it, doing so means we can remove the "mustexist" > condition, and therefore anything except the "flags = > RESOLVE_REF_NO_RECURSE" case. Furthermore, since the verify_lock() > function we called did most of its work when the "oid" was passed (as > "old_oid") we can inline the trivial part of it that remains in what's > now its only caller. > [...] > 1 file changed, 12 insertions(+), 60 deletions(-) Sounds good, and the diffstat is very pleasing. :) The patch itself looks correct to me. -Peff
