Taylor Blau wrote: > On Thu, Jul 15, 2021 at 12:35:30PM -0400, Eric Sunshine wrote: > > On Thu, Jul 15, 2021 at 12:25 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines > > > @@ -541,6 +541,49 @@ Writing Documentation: > > > + A contributor asks their upstream to pull from them. > > > + > > > + Note that this sounds ungrammatical and unnatural to those who > > > + learned English as a second language in some parts of the world. > > > > It also sounds ungrammatical and unnatural to this native English speaker. > > Apologies if this suggestion has been made earlier in the thread, but > this article > > https://apastyle.apa.org/style-grammar-guidelines/grammar/singular-they > > document from the APA's style guide helps convince me that this is > grammatical. That's the opinion of one organization (biased in my opinion). Other organizations disagree: https://ahdictionary.tumblr.com/post/147597257733/updated-usage-note-they -- Felipe Contreras
