On Fri, Jul 16, 2021 at 02:09:22PM -0400, Jeff King wrote: > > Anything that's a lot more granular than that is doing to suck, > > e.g. exposing teh GIT_TEST_SKIP and --run features. of specific test > > numbers, now you need to count your tests if you add one in the middle > > of one of those, and more likely you won't test under the mode and just > > see it in CI. > > I think you can do the same level of skipping with GIT_TEST_SKIP, > though. My argument was just that adding a new mechanism does not make > sense when we already have one. I.e., running: > > GIT_SKIP_TESTS=' > t[123456789]* > t0[^0]* > t00[^016]* > t000[469] > t001[2459] > t006[0248] > ' make SANITIZE=leak test > > works already to do the same thing. The only thing we might want is a > nicer syntax (e.g., to allow positive and negative patterns, or to read > from a file). But that would benefit all users of GIT_SKIP_TESTS, not > just people interested in leaks. I cheated a little here; an unrelated bug does cause a failure in t0000 with this pattern. I've just sent: https://lore.kernel.org/git/YPHTY5G9JaQFKlX5@xxxxxxxxxxxxxxxxxxxxxxx/ to fix it. -Peff
