Re: [PATCH] parse-options: don't complete option aliases by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felipe,

Le 2021-07-15 à 13:04, Felipe Contreras a écrit :
Philippe Blain via GitGitGadget wrote:
From: Philippe Blain <levraiphilippeblain@xxxxxxxxx>


Helpfully, since 64cc539fd2 (parse-options: don't leak alias help
messages, 2021-03-21) these copies have the PARSE_OPT_FROM_ALIAS flag
set, so check that flag early in 'show_gitcomp' and do not print them,

Makes sense but I don't think what the patch is doing should be buried
here. I think a separate paragraph explaining what you are trying to do
will be better.

Indeed. Will clarify.



I agree this is better, and the patch itself looks obviously correct.

Reviewed-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>


Thanks!

Philippe.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux