"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx>
writes:
> Unfortunately, this means that we no longer can rely on a shallow clone:
> There is no way of knowing just how many commits the upstream branch
> advanced after the commit from which the PR branch branched off. So
> let's just go with a full clone instead, and be safe rather than sorry
> (if we have "too shallow" a situation, a commit range `@{u}..` may very
> well include a shallow commit itself, and the output of `git show
> --check <shallow>` is _not_ pretty).
Makes sense.
As long as you have pull-request base, I suspect that you could
shallow clone the base and incrementally fetch the rest to update,
perhaps? But I do not know if it is worth doing so for a small
project like ours.
Thanks.
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> ---
> .github/workflows/check-whitespace.yml | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/.github/workflows/check-whitespace.yml b/.github/workflows/check-whitespace.yml
> index c53614d6033..8c4358d805c 100644
> --- a/.github/workflows/check-whitespace.yml
> +++ b/.github/workflows/check-whitespace.yml
> @@ -12,15 +12,9 @@ jobs:
> check-whitespace:
> runs-on: ubuntu-latest
> steps:
> - - name: Set commit count
> - shell: bash
> - run: echo "COMMIT_DEPTH=$((1+$COMMITS))" >>$GITHUB_ENV
> - env:
> - COMMITS: ${{ github.event.pull_request.commits }}
> -
> - uses: actions/checkout@v2
> with:
> - fetch-depth: ${{ env.COMMIT_DEPTH }}
> + fetch-depth: 0
>
> - name: git log --check
> id: check_out
> @@ -47,7 +41,7 @@ jobs:
> echo "${dash} ${etc}"
> ;;
> esac
> - done <<< $(git log --check --pretty=format:"---% h% s" -${{github.event.pull_request.commits}})
> + done <<< $(git log --check --pretty=format:"---% h% s" ${{github.event.pull_request.base.sha}}..)
>
> if test -n "${log}"
> then
