Hi Philip, On Tue, 13 Jul 2021, Philip Oakley wrote: > On 13/07/2021 13:19, Johannes Schindelin wrote: > > > > On Sun, 4 Jul 2021, Ævar Arnfjörð Bjarmason wrote: > > > >> On Wed, Jun 23 2021, Dennis Ameling via GitGitGadget wrote: > >> > >>> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > >>> index 0f7516c9ef..3b40c677ab 100644 > >>> --- a/.github/workflows/main.yml > >>> +++ b/.github/workflows/main.yml > >>> @@ -159,7 +159,7 @@ jobs: > >>> shell: bash > >>> run: | > >>> cmake `pwd`/contrib/buildsystems/ -DCMAKE_PREFIX_PATH=`pwd`/compat/vcbuild/vcpkg/installed/x64-windows \ > >>> - -DMSGFMT_EXE=C:/git-sdk-64-minimal/mingw64/bin/msgfmt.exe -DPERL_TESTS=OFF -DPYTHON_TESTS=OFF -DCURL_NO_CURL_CMAKE=ON > >>> + -DNO_GETTEXT=YesPlease -DPERL_TESTS=OFF -DPYTHON_TESTS=OFF -DCURL_NO_CURL_CMAKE=ON > >>> - name: MSBuild > >>> run: msbuild git.sln -property:Configuration=Release -property:Platform=x64 -maxCpuCount:4 -property:PlatformToolset=v142 > >>> - name: bundle artifact tar > >> To a first approximation isn't the point of CI to test a diversity of > >> setups? > > No, the point of CI is to find breakages. > > This problem (vcpkg/VS/CI build breakage for the tar artifact) has also > just come up for me on > https://github.com/git-for-windows/git/pull/3306#issuecomment-879093798 > "[RFC] making Git for Windows start buildins in modern Visual Studio > #3306" which is a similar build situation. > > Hopefully we can chose a suitable solution regarding what, if any, extra > checks this part of the CI build ought to do with the (unused in this > build) `.mo` files. You will be happy to hear that the fix was in v2 of this patch series (you responded to v1). Ciao, Dscho
