On Wed, Jul 14, 2021 at 10:40 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > >> It adds resolve_refs_unsafe_with_errno() to the public API in refs.h, > >> and I think it has an ugly signature, but I suppose it's better than > >> having the output be implicit through the global errno variable. > > > > Yeah it is a bit ugly, perhaps we should just end up using the old name > > once there's no callers of the old one? > > I looked at doing this, I don't think it's worth it. .. > And in any case with reftable I suspect that we'll end up refactoring > further down the line sooner than later, i.e. to pass a "struct strbuf > *err" or something, so getting it 100% right here seems premature. SGTM. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
