Re: [PATCH v2 2/7] merge-ort: add some more explanations in collect_merge_info_callback()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/07/21 02.32, Elijah Newren via GitGitGadget wrote:
@@ -1018,8 +1018,8 @@ static int collect_merge_info_callback(int n,
  	if (side1_matches_mbase && side2_matches_mbase) {
  		/* mbase, side1, & side2 all match; use mbase as resolution */
  		setup_path_info(opt, &pi, dirname, info->pathlen, fullpath,
-				names, names+0, mbase_null, 0,
-				filemask, dirmask, 1);
+				names, names+0, mbase_null, 0 /* df_conflict */,
+				filemask, dirmask, 1 /* resolved */);
  		return mask;
  	}



Is df_conflict stands for directory-file conflict?

  	/*
-	 * Record information about the path so we can resolve later in
-	 * process_entries.
+	 * None of the special cases above matched, so we have a
+	 * provisional conflict.  (Rename detection might allow us to
+	 * unconflict some more cases, but that comes later so all we can
+	 * do now is record the different non-null file hashes.)
  	 */
  	setup_path_info(opt, &pi, dirname, info->pathlen, fullpath,
  			names, NULL, 0, df_conflict, filemask, dirmask, 0);


So when none of special cases matched, we assumed there's conflict (although provisional), right?

--
An old man doll... just what I always wanted! - Clara



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux