On Tue, 13 Jul 2021 at 09:52, Jeff King <peff@xxxxxxxx> wrote: > > [+cc Junio; this patch looks good to me, and should go on top of > jk/log-decorate-optim, which is in 'next' and has a pretty > ugly regression] Thanks for calling out the branch name when I failed to. That's indeed where my copy of the patch sits and where I've tested this. > > Maybe you wrote this before circling back and actually writing that > > "even better" thing? Because it seems to me like that's what you did. > > Maybe I'm still missing something. > > Nope, I'm just dumb. I wrote what I sent in the other email (rather than > just adding the "if" as above) because it only involved having a single > parse_object() call in the function. To my credit, I did realize about > an hour after sending the other email that I had in fact done the > "better thing" quite accidentally. But I really like how you explained > it in the commit message here, which I had not quite thought through. That's the best kind of hindsight: the sudden realization that you actually got it right. > Patch looks good. Thanks for noticing the problem and cleaning up my > mess. Thanks a lot for your comments and all the help. I'm glad you liked my explanation in the posted patch. Martin
