On Mon, Jul 12, 2021 at 11:56 PM Jeff King <peff@xxxxxxxx> wrote: > On Mon, Jul 12, 2021 at 10:22:22PM -0400, Eric Sunshine wrote: > > On Mon, Jul 12, 2021 at 8:16 PM Jeff King <peff@xxxxxxxx> wrote: > > > And indeed, Lénaïc's patches use it elsewhere. I think it doesn't work > > > in this instance because it can't take an arbitrary delimiter. But I > > > wouldn't at all mind seeing it grow that feature (and I suspect it could > > > even share some code with string_list_split(), but didn't look). > > > > Since Lénaïc is a relative newcomer to the project, can we, as > > reviewers, be clear that we don't expect him to perform the task of > > generalizing strvec_split() just to get this series -- which is > > already at v7 -- landed? > > Yeah, sorry if I was unclear on that. That is absolutely not a > requirement for this series. Thanks, and sorry if my response seemed to be aimed only at your reply. It wasn't. It was a reaction to a number of recent reviews -- in general -- containing only subjective comments or a mix of subjective comments and genuine actionable items without necessarily making it clear which is which. Such ambiguity is hard on newcomers, who may end up doing unnecessary work trying to get their patches accepted, or might scare them away altogether.
