On Sat, Jul 10, 2021 at 8:27 PM Stephen Manz via GitGitGadget
<gitgitgadget@xxxxxxxxx> wrote:
> Changes since v2:
> * Updated second commit to wrap "initializing" string with _() to mark it
> for translation, as requested. I had originally opted not to mark it,
> since, when --lock is not given, file locked gets removed after the
> working tree is populated. Thus, it's not really user-facing. Modified
> the commit message accordingly.
True. Makes sense. A side-benefit of wrapping it in `_(...)`, though,
is that it saves the next person who touches that code from wondering
why only one of the messages has been localized, so it's nice to see
the revised patch making both strings localizable.
I read over the series and played around with the implementation. It
all looks good. With or without addressing the couple extremely minor
comments I left on patch [3/3] regarding one of the tests, consider
this series:
Reviewed-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
Thanks.
