On Sat, Jul 10, 2021 at 10:47:26AM +0200, Ævar Arnfjörð Bjarmason wrote: > Adds missing add missing __attribute__((format)) in various places, > which improves compile-time checking. Thanks, this is definitely worth doing. There were more of these than I expected. Patches 1-3 look obviously good. I didn't double-check all of your parameter-numbers, but the compiler should make it painfully obvious if you got any wrong. :) I'm iffy on the strftime and compat things in the latter patches; I left more detailed responses there. -Peff