Pierre Habouzit <madcoder@xxxxxxxxxx> writes: > On Wed, Sep 05, 2007 at 08:39:52AM +0000, Matthieu Moy wrote: >> Johan Herland <johan@xxxxxxxxxxx> writes: >> >> > When git-fetch and git-commit has done its job and is about to exit, it checks >> > the number of loose object, and if too high tells the user something >> > like "There are too many loose objects in the repo, do you want me to repack? >> > (y/N)". If the user answers "n" or simply <Enter>, >> >> I don't like commands to be interactive if they don't _need_ to be so. >> It kills scripting, it makes it hard for a front-end (git gui or so) >> to use the command, ... > > There is absolutely no problem here, as it can be avoided if the > output is not a tty. Which output? stdout? stderr? Where is the question appearing? What if the command has been started in the background? What if stdin (not stdout) is from a pipe, maybe for taking a commit message? What if stdin is from a pseudo-tty because the commit has been started with an internal shell command inside of Emacs, and the command/message will only get echoed once git-commit completes? > It's not _that_ hard to guess if you're currently running in a > script or in an interactive shell after all. Oh, it is not hard to _guess_. Just throw a die. What is hard is to _know_ 100% sure that one is doing the right thing and not breaking any legitimate use. -- David Kastrup - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
