Re: [PATCH 2/3] archive: specfile support (--pretty=format: in archive files)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 5 Sep 2007, Ren? Scharfe wrote:

> Johannes Schindelin schrieb:
> 
> > On Tue, 4 Sep 2007, Andreas Ericsson wrote:
> > 
> >> Junio C Hamano wrote:
> >>> Ren? Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes:
> >>>
> >>>> The attribute is useful for creating auto-updating specfiles.  It is 
> >>>> limited by the underlying function format_commit_message(), though. 
> >>>> E.g. currently there is no placeholder for git-describe like output, 
> >>>> and expanded specfiles can't contain NUL bytes.  That can be fixed 
> >>>> in format_commit_message() later and will then benefit users of 
> >>>> git-log, too.
> >>> Interesting. I however wonder if "specfile" is a good name for this 
> >>> attribute, although I admit I do not think of anything better offhand.
> >> "releasefile", perhaps?
> > 
> > Maybe we should not so much name it by purpose, but by function.  How 
> > about "substformat" for the attribute name, and replacing any 
> > $Format:blablub$ inside those files with something a la 
> > --pretty=format:blablub?
> 
> I like the $Format:...$ notation.  How about naming the attribute
> "template", as that's what a thus marked file is?

Unless somebody comes up with an even better name, yes (I like "template" 
better than "substformat" or "releasefile", but I still think that 
"template" is not descriptive enough).

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux