Re: [PATCH 3/3] strbuf.[ch]: make strbuf_fread() take hint, not size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 3/3] strbuf.[ch]: make strbuf_fread() take hint, not size
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Wed, 07 Jul 2021 14:27:58 -0700
Cc: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>, git@xxxxxxxxxxxxxxx, Jeff King <peff@xxxxxxxx>
In-reply-to: <CAFQ2z_MWMokX8hXdOJfiL9Yn=F-QUWe5VHXFEF5DoSBBJu=dmw@mail.gmail.com> (Han-Wen Nienhuys's message of "Wed, 7 Jul 2021 13:47:00 +0200")
References: <cover-0.3-00000000000-20210707T103712Z-avarab@gmail.com> <patch-3.3-46c65a7ae12-20210707T103712Z-avarab@gmail.com> <CAFQ2z_MWMokX8hXdOJfiL9Yn=F-QUWe5VHXFEF5DoSBBJu=dmw@mail.gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Han-Wen Nienhuys <hanwen@xxxxxxxxxx> writes:

> shouldn't you rename it to strbuf_fread_once, analogous to strbuf_read_once ?

Good point.

References:
- [PATCH 0/3] strbuf.[ch]: add STRBUF_HINT_SIZE, don't hardcode 8192
  - From: Ævar Arnfjörð Bjarmason
- [PATCH 3/3] strbuf.[ch]: make strbuf_fread() take hint, not size
  - From: Ævar Arnfjörð Bjarmason
- Re: [PATCH 3/3] strbuf.[ch]: make strbuf_fread() take hint, not size
  - From: Han-Wen Nienhuys

Prev by Date: What actually is a branch?
Next by Date: Question regarding Version Control with Git 2nd
Previous by thread: Re: [PATCH 3/3] strbuf.[ch]: make strbuf_fread() take hint, not size
Next by thread: Bug with branches/merges in submodules
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux