René Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: > Here's that ugly code, by the way. It adds two placeholders, %d for > description and %D for description depth. Shortcomings of this code: > it adds three members to struct commit, it unconditionally computes > the description when format_commit_message() -- even if the format > string doesn't contain %d and %D, the patch is not nicely split up. > But it convinced me that describe *can* indeed be librarified. :-) Yeah, unconditional computation for %d/%D is really a killer. Otherwise the change itself does not necessarily look too ugly, though. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
