Re: [PATCH] commit: remove irrelavent prompt on `--allow-empty-message`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano wrote:
> Hu Jialun <hujialun@xxxxxxxxxxxxxxx> writes:
> 
> > Currently, COMMIT_EDITMSG contains "...and an empty message aborts the
> > commit", regardless of whether the --allow-empty-message option is
> > specified or not. This is deemed confusing and unintended.
> 
> I have to wonder what reason a user have to use that option, other
> than wanting to record a commit without any message.  In other words,
> wouldn't it be a bug for this command 
> 
>     $ git commit --allow-empty-message
> 
> to open an editor to allow editing the message, instead of just
> committing with an empty message?

To translate this question into more programmatical terms.

Should this commit an empty message?

  % git commit --allow-empty-message -m "$msg"

I say the answer is no.

We need to know what the message is.

-- 
Felipe Contreras



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux