On Mon, Jun 28, 2021 at 9:19 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > Now that we've factored out "call_{advertise,command}()" in a > preceding commit it becomes easy to trace all these callbacks with > trace2. Let's do that. As the tests demonstrate there's no v2 push > protocol, which the tests assert. code looks good, but confused about the objective. This isn't necessary for the rest of the series, is it? cleanup changes leading up to here LGTM. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado