On Sat, Jul 03 2021, Jeff King wrote: > On Fri, Jul 02, 2021 at 11:57:29AM +0200, Ævar Arnfjörð Bjarmason wrote: > >> This re-roll of v3 changes the discussion in the 1/3 commit message, >> it incorrectly referred to SANITIZE=leak when I meant valgrind. >> >> I also changed the bundle_header_init() pattern to use the same >> "memcpy() a blank" as in my parallel series to do that more generally. > > Thanks, this looks good to me. > > I'd probably word the discussion about die() a bit differently, but you've > already seen my expositions on leak-checking, and it's all tangent here. > So let's move forward with this, and we can let leak-checking > philosophies iron themselves out as we fix more cases. :) Thanks for the detailed review over multiple rounds.
