On Tue, Sep 04, 2007 at 03:44:30PM +0000, Johannes Schindelin wrote:
> Hi,
>
> On Tue, 4 Sep 2007, Pierre Habouzit wrote:
>
> > +void strbuf_grow(struct strbuf *sb, size_t extra) {
> > + if (sb->len + extra + STRBUF_GROW_STEP < sb->len)
> > + die("you want to use way to much memory");
> > +
> > + sb->alloc = ((sb->len + extra) + STRBUF_GROW_STEP) & ~(STRBUF_GROW_STEP - 1);
> > + sb->buf = xrealloc(sb->buf, sb->alloc);
> > +}
>
> Why not use ALLOC_GROW()? Seems to me more efficient than growing by 1kB
> blocks all the time, for big strings as for short strings.
ooooh, now I'm guilty of not knowing all git APIs very well yet :) Indeed,
this should just be:
void strbuf_grow(struct strbuf *sb, size_t extra) {
if (sb->len + extra + 1 < sb->len)
die("you want to use way to much memory");
ALLOC_GROW(sb->buf, sb->len + extra + 1, sb->alloc);
}
This is definitely better on so many levels !
--
·O· Pierre Habouzit
··O madcoder@xxxxxxxxxx
OOO http://www.madism.org
Attachment:
pgpSi6V6tL2mR.pgp
Description: PGP signature
