On Mon, Jun 28 2021, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> A small series to fix the various "tags" targets, i.e. "make tags TAGS >> cscope". We'll now properly detect their dependencies, so we don't >> needlessly run them every time. I have this as part of my standard >> "make git" command, so doing nothing when we have nothing to do is >> preferrable, especially when my editor will eagerly reload the TAGS >> file every time it changes. >> >> As noted in 3/3 this is better on top of my just-submitted >> .DELETE_ON_ERROR change[1], but will also work independently of that >> patch/series. >> >> 1. https://lore.kernel.org/git/patch-1.1-9420448e74f-20210622T141100Z-avarab@xxxxxxxxx/ >> >> Ævar Arnfjörð Bjarmason (3): >> Makefile: move ".PHONY: cscope" near its target >> Makefile: fix "cscope" target to refer to cscope.out >> Makefile: don't use "FORCE" for tags targets >> >> .gitignore | 2 +- >> Makefile | 31 +++++++++++++++++-------------- >> 2 files changed, 18 insertions(+), 15 deletions(-) > > Looks mostly like good patches, with concrete suggestions for > improvements given. Please do not leave another loose end that > should be easy to tie untied and float away to some other topics. In the v2 re-roll of both I detached these two topics from each other, as it turns out it wasn't needed to begin with. Sorry about that.