Hi, On Tue, 4 Sep 2007, Carlos Rica wrote: > Signed-off-by: Carlos Rica <jasampler@xxxxxxxxx> > --- > > They are designed to be reused also from other builtins, > like the recently changed builtin-tag.c and the upcoming > builtin-reset.c, and perhaps also from builtin-fetch--tool.c. This should go into the commit message. > +int update_ref_or_die(const char *action, const char *refname, > + const unsigned char *sha1, > + const unsigned char *oldval, int flags) Should this not be "void"? And should it not use update_ref_or_error()? Otherwise I like it. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
