On Thu, Jun 24 2021, SZEDER Gábor wrote: > On Wed, Jun 23, 2021 at 11:57:32PM +0200, SZEDER Gábor wrote: >> I just wanted to see whether it's possible to check all progress lines >> and whether it uncovers any more bugs; and the answer is yes to both. > > Oh, and there is another one: > > test_expect_success 'test' ' > git commit --allow-empty -m 1 && > git commit --allow-empty -m 2 && > git commit --allow-empty -m 3 && > GIT_PROGRESS_DELAY=0 \ > git commit-graph write --progress --reachable --split && > git commit --allow-empty -m 4 && > GIT_PROGRESS_DELAY=0 \ > git commit-graph write --progress --reachable --split > ' > > The last command's progress output ends with: > > Writing out commit graph in 5 passes: 80% (4/5), done. > > This is because since 53035c4f0b (commit-graph write: add "Writing > out" progress output, 2019-01-19) we have assumed that the work done > while writing each chunk is proportional to the number of commits in > the graph, but with the arrival of split commit graphs and the BASE > chunk in 118bd57002 (commit-graph: add base graphs chunk, 2019-06-18) > that's not longer the case. Ah, I encountered the off-by-something in that "writing in N passes" but didn't find the root cause, thanks.
