On 24/06/21 01.39, Taylor Blau wrote:
But it does not check that the file's trailing checksum matches the data
that it records. So, if an on-disk corruption happened to occur in the
final few bytes (and all other data was recorded correctly), we would:
- get a clean result from 'git multi-pack-index verify', but
- be unable to reuse the existing MIDX when writing a new one (since
we now check for checksum mismatches before reusing a MIDX)
Teach the 'verify' sub-command to recognize corruption in the checksum
by calling midx_checksum_valid().
...
+ if (!midx_checksum_valid(m))
+ midx_report(_("incorrect checksum"));
+
...
+test_expect_success 'verify incorrect checksum' '
+ pos=$(($(wc -c <$objdir/pack/multi-pack-index) - 1)) &&
+ corrupt_midx_and_verify $pos "\377" $objdir "incorrect checksum"
+'
+
We're in the context of checksum mismatches because of on-disk
corruption, so why didn't the message say "incorrect checksum, possibly
corrupt"?
--
An old man doll... just what I always wanted! - Clara
