Christian Couder <christian.couder@xxxxxxxxx> 于2021年6月21日周一 下午8:07写道： > > On Sun, Jun 20, 2021 at 6:53 PM ZheNing Hu <adlternative@xxxxxxxxx> wrote: > > > > My fifth week blog finished: > > The web version is here: > > https://adlternative.github.io/GSOC-Git-Blog-5/ > > Great, thanks! > > > ## Week5: Tempting apple > > > > This week, I spent a lot of time working on the digital circuit > > course design of the school. So this week's patches for git > > was completed in a hurry. This week `Ævar Arnfjörð Bjarmason` > > s/was/were/ > > > gave a lot of useful suggestions for the patch I wrote earlier. > > Maybe a link could help. > > > Some are related to code style improvements, and some are > > better design ideas. > > [...] > > > But something like `fill_remote_ref_details()`, things gradually > > become complicated and difficult. `fill_remote_ref_details()`. > > I think you can remove the above `fill_remote_ref_details()` as you > are talking about it later. > OK. > > * FootNote: > > 1. Why is there no `strbuf_empty()` in `strbuf` API? I think this may be > > a very important thing. > > There is a 'size_t len' field in 'struct strbuf', so doing `buf->len > == 0` works. > Really? So I think for reader who is learning strbuf api for the first time, the characteristics of empty strbuf are not so obvious. For example, `strbuf_slopbuf` may mean "empty". In any case, adding a macro is absolutely reasonable and will not affect performance. #define strbuf_empty(sb) (sb->len == 0) > > 2. Another thing worth mentioning is: I will have the school final exam > > between July 7th and July 14th, I may be busy during this period. > > Ok, thanks for telling us in advance. Correct the time deviation, the examination time is from July 1st to July 12th. -- ZheNing Hu
