Felipe Contreras wrote: > From: "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> > > Asciidoctor contains a converter to generate man pages. In some > environments, where building only the manual pages and not the other > documentation is desired, installing a toolchain for building > DocBook-based manual pages may be burdensome, and using Asciidoctor > directly may be easier, so let's add an option to build manual pages > using Asciidoctor without the DocBook toolchain. This suffices: There's no need to use xmlto to build the man pages when modern asciidoctor can do it by itself. > We generally require Asciidoctor 1.5, but versions before 1.5.3 didn't > contain proper handling of the apostrophe, which is controlled normally > by the GNU_ROFF option. This isn't true. There's no difference from 1.5, 1.5.3, 2.0.0 or even 2.0.15. The only fix regarding apostrophes was done by me [1], it's in the master branch, but not in any release yet. > This option for the DocBook toolchain, as well > as newer versions of Asciidoctor, makes groff output an ASCII apostrophe > instead of a Unicode apostrophe in text, so as to make copy and pasting > commands easier. That isn't true. GNU_ROFF is only for docbook and doesn't affect asciidoctor in any way. > These newer versions of Asciidoctor (1.5.3 and above) > detect groff and do the right thing in all cases, so the GNU_ROFF option > is obsolete in this case. Not true. There's nothing in 1.5.3 or any version that detects groff, or have anything to do with GNU_ROFF. > Because Asciidoctor versions before 2.0 had a few problems with man page > output, let's default this to off for now, since some common distros are > still on 1.5. There's nothing from 1.5.8 to 2.0.0 that should be of interest to the git project. What are these "few problems"? The diff is correct, but 1) the original patch was done by me, and 2) I already have the exact same version here [2]. Cheers. [1] https://github.com/asciidoctor/asciidoctor/commit/af0ef59538fccfbdec053b82e102a240b15cdda6 [2] https://lore.kernel.org/git/20210521224452.530852-4-felipe.contreras@xxxxxxxxx/ -- Felipe Contreras
