Hi Philip, On Fri, 18 Jun 2021, Philip Oakley wrote: > On 10/06/2021 10:43, Johannes Schindelin wrote: > > > > On Sat, 5 Jun 2021, Bagas Sanjaya wrote: > > > >> This focused on improving CMake support, especially on Visual Studio, right? > >> > >> Then so we have three ways to build Git: > >> 1. plain Makefile > >> 2. ./configure (really just wrapper on top of Makefile) > >> 3. generate build file with CMake > >> > >> If we want to support all of them, it may makes sense to have CI jobs that > >> perform build with each options above. > > > > We already exercise the plain Makefile plenty, and the CMake-based build > > using Windows (in the `vs-build` job in `.github/workflows/main.yml`). > > There is one 'gotcha' in the yml (probably historical) in that it > doesn't actually test the approach/changes that Matt addresses regarding > my [1]. > > That is, I'm looking at the 'out of the box' view, while the yml test > _preloads_ the vcpkg artefacts. We need to "pre-load" them because building them would add another whopping 20 minutes to each CI run. And I am not talking total time, but wall-clock time. And we're not in the business of testing vcpkg's build. So I am really not in favor of even thinking about changing this "pre-loading" strategy. Ciao, Dscho
