Hi Simon, On Thu, 17 Jun 2021, Simon Hausmann wrote: > On Fri, Mar 12, 2021 at 07:47:49AM +0000, dorgon chang via GitGitGadget wrote: > > From: "dorgon.chang" <dorgonman@xxxxxxxxxxx> > > > > If the submit contain binary files, it will throw exception and stop submit when try to append diff line description. > > > > This commit will skip non-text data files when exception UnicodeDecodeError thrown. > > > > Signed-off-by: dorgon.chang <dorgonman@xxxxxxxxxxx> > > As suggested on > https://github.com/git/git/pull/977#issuecomment-862197824, I'm happy to > state that the patch looks good to me. IIRC the diff there is solely for > the submit template, so it should only include text. That your patch > ensures in what seems an idiomatic way. Thank you for reviewing and chiming in. > Signed-off-by: Simon Hausmann <simon@xxxxxx> The typical way to record your review is to say `Reviewed-by:`. The `Signed-off-by:` footer is usually used to indicate that you wrote the patch, or that you shepherd it onto the Git mailing list. Sorry to be so nit-picky... Thanks, Dscho
