On Thu, Jun 17 2021, Felipe Contreras wrote: > Ævar Arnfjörð Bjarmason wrote: >> Change various places that hardcode the names of these two files to >> refer to either $(GENERATED_H), or to a new generated-hdrs >> target. > > Avoiding hard-coded things is generally a good idea, and I can smell > there's an advantage nearby, but it's not stated. > > Can you spell out what you are trying to achieve? It's hinted at in the CL, but this is series 1/3 of a re-roll of the base topic for config-based hooks, real use of this is made in step 2/3, 3/3 has a better overview: http://lore.kernel.org/git/cover-00.27-0000000000-20210617T101216Z-avarab@xxxxxxxxx >> Hardcoding command-list.h there seems to have been a case of >> copy/paste programming in dce7d29551 (msvc: support building Git using >> MS Visual C++, 2019-06-25). > > Actually that's not the commit, it's this one: > > 976aaedca0 (msvc: add a Makefile target to pre-generate the Visual > Studio solution, 2019-07-29) Thanks, I had both in my buffers somewhere and copied over the wrong one. Will correct pending further feedback...
