Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > On Wed, Jun 16, 2021 at 10:16 AM Ævar Arnfjörð Bjarmason > <avarab@xxxxxxxxx> wrote: >> The has_capability() function introduced in ed10cb952d3 (serve: >> introduce git-serve, 2018-03-15) has never been used anywhere except >> serve.c, so let's mark it as static. >> >> It was later changed from "extern" in 554544276a6 (*.[ch]: remove >> extern from function declarations using spatch, 2019-04-29), but we >> could have simply marked it as "static" instead. >> >> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> >> --- >> diff --git a/serve.h b/serve.h >> @@ -2,9 +2,6 @@ >> struct strvec; >> -int has_capability(const struct strvec *keys, const char *capability, >> - const char **value); >> - > > `strvec` isn't used anywhere in this header following removal of > has_capability(), so the forward declaration could be dropped, as > well. Good eyes.
