Ævar Arnfjörð Bjarmason wrote: > > On Sun, Jun 13 2021, Felipe Contreras wrote: > > > These have been stable and widely used for quite a long time, they even > > have tests outside of the contrib area, and most distributions ship > > them, so they can be considered part of the core already. > > > > We should be consistent and either we move the tests to contrib, or we > > move the completions out of contrib. > > > > Let's move them out of contrib and provide an installation target > > install-extra. > > > > By default bash-completion installs the completions to > > $(pkgdatadir)/completions, which is > > $(prefix)/share/bash-completion/completions. And since most distributions do > > not change this, it is obviously the right default that distributions > > can override with bashcompdir. > > > > By default zsh looks for completions in > > $(prefix)/share/zsh/site-functions. > > > > Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> > > --- > > Makefile | 3 +++ > > extra/Makefile | 17 +++++++++++++++++ > > Please let's not continue following the IMO anti-pattern of having these > sub-Makefiles. Let's just add the target to the top-level Makefile. All right. Fine by me. -- Felipe Contreras
