On Sun, Jun 13, 2021 at 01:00:33PM -0500, Felipe Contreras wrote: > > > I'm re-sending this patch from 2013 because I do think it provides value > > > and we might want to make it the default. > > > > I take it you didn't investigate the segfault I mentioned. > > I don't know how I was supposed to investigate the few segfaults you > mentioned. All you said is that you never tracked the bug. My point is that if you are going to repost a patch that has known problems, it is worth saying so to give reviewers and the maintainer a realistic idea of how stable it is. I also didn't have a reproduction recipe. I found the commit I sent by just re-running every merge in git.git in a loop. It sounds like you have a smaller reproduction and maybe a fix, which is good. -Peff