On 6/10/2021 8:50 PM, Taylor Blau wrote: > On Fri, Jun 11, 2021 at 01:56:31AM +0200, Ævar Arnfjörð Bjarmason wrote: >> So yeah, maybe we can just unlink() them right away, or another way to >> handle the race is that load_commit_graph_chain() could just try again >> from the beginning in such a case, and presumably picking up the fresh >> just-rewritten chain. > > I'd probably be in favor of the latter. I want to point out that on Windows we cannot successfully unlink() a layer that is currently being read by another Git process. That will not affect server scenarios (to the best of my knowledge) but is important to many end users. Thanks, -Stolee
